Avoid non-public promote_op in OptimizationBase#1249
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Avoid non-public promote_op in OptimizationBase#1249ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
Base.promote_opdependency inOptimizationDIExt.jlwith a local public-API eltype helperRoot cause
OptimizationBaseQA on master failed ExplicitImports becauseBase.promote_opis not public API.Validation
OPTIMIZATION_TEST_GROUP=QA /home/crackauc/.juliaup/bin/julia +1.12 --project=lib/OptimizationBase -e 'import Pkg; Pkg.test(; julia_args=["--check-bounds=yes", "--compiled-modules=yes", "--depwarn=yes"], force_latest_compatible_version=false, allow_reresolve=false)'\n - observed:Quality Assurance | 17 1 18,Testing OptimizationBase tests passed\n-OPTIMIZATION_TEST_GROUP=Core /home/crackauc/.juliaup/bin/julia +1.12 --project=lib/OptimizationBase -e 'import Pkg; Pkg.test(; julia_args=["--check-bounds=yes", "--compiled-modules=yes", "--depwarn=yes"], force_latest_compatible_version=false, allow_reresolve=false)'\n - observed in the original worktree with the same file diff:Core | 777 777,Testing OptimizationBase tests passed\n-timeout 3600 /home/crackauc/.juliaup/bin/julia +1.12 --startup-file=no -e 'import Pkg; Pkg.activate(; temp=true); Pkg.add("Runic"); using Runic; exit(Runic.main(["--check", "."]))'\n-git diff --check